Fix panic triggered by boxed Channel instances #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rf-figma
force-pushed
the
fix-channel-panic
branch
from
370f0ec to
673e9a1
Compare
This fixes a bug that can be triggered when there's a JsBox holding an instance of Channel at the moment the VM stops (e.g., when quitting an Electron app). The Channel's `drop` implementation calls `self.send`, which panics with a SendError because we're already in the middle of tearing everything down.
rf-figma
force-pushed
the
fix-channel-panic
branch
from
673e9a1 to
9d22944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that can be triggered when there's a JsBox holding an instance of Channel at the moment the VM stops (e.g., when quitting an Electron app). The Channel's
dropimplementation callsself.send, which panics with a SendError because we're already in the middle of tearing everything down.